Skip to content

[Notifier] use attribute rather than annotation #19619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 29, 2024
Merged

[Notifier] use attribute rather than annotation #19619

merged 1 commit into from
Feb 29, 2024

Conversation

tacman
Copy link
Contributor

@tacman tacman commented Feb 29, 2024

No description provided.

@javiereguiluz javiereguiluz added this to the 6.4 milestone Feb 29, 2024
@carsonbot carsonbot changed the title use attribute rather than annotation [Notifier] use attribute rather than annotation Feb 29, 2024
@javiereguiluz javiereguiluz changed the base branch from 7.0 to 6.4 February 29, 2024 12:44
@javiereguiluz javiereguiluz merged commit 2ea307f into symfony:6.4 Feb 29, 2024
@javiereguiluz
Copy link
Member

Thanks Tac!

smnandre added a commit to smnandre/symfony-docs that referenced this pull request Mar 2, 2024
@smnandre
Replace Annotation\Route with Attribute\Route
3246095 
Inspired by symfony#19619 :)
@smnandre smnandre mentioned this pull request Mar 2, 2024
Merged
javiereguiluz added a commit that referenced this pull request Mar 4, 2024
@javiereguiluz
minor #19623 Replace Annotation\Route with Attribute\Route (smnandre)
b8f6679 
This PR was merged into the 6.4 branch.

Discussion
----------

Replace Annotation\Route with Attribute\Route

Inspired by #19619 :)

Commits
-------

3246095 Replace Annotation\Route with Attribute\Route
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh

@OskarStark OskarStark Awaiting requested review from OskarStark

Assignees
No one assigned
Labels
Notifier Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
3 participants
@tacman @javiereguiluz @carsonbot